Closed junaruga closed 7 years ago
https://travis-ci.org/jonleighton/spring-watcher-listen/builds/224408322
Only Ruby 2.2.7 test was failed. Is this a known or temporary issue?
1) Error:
AcceptanceTest#test_app_gets_reloaded_even_with_a_ton_of_boot_output:
Errno::EBADF: Bad file descriptor
/home/travis/.rvm/gems/ruby-2.2.7/bundler/gems/spring-d1ae63061326/lib/spring/test/application.rb:157:in `select'
/home/travis/.rvm/gems/ruby-2.2.7/bundler/gems/spring-d1ae63061326/lib/spring/test/application.rb:157:in `read_stream'
/home/travis/.rvm/gems/ruby-2.2.7/bundler/gems/spring-d1ae63061326/lib/spring/test/application.rb:151:in `read_streams'
/home/travis/.rvm/gems/ruby-2.2.7/bundler/gems/spring-d1ae63061326/lib/spring/test/application.rb:118:in `run'
/home/travis/.rvm/gems/ruby-2.2.7/bundler/gems/spring-d1ae63061326/lib/spring/test/acceptance_test.rb:43:in `assert_success'
/home/travis/.rvm/gems/ruby-2.2.7/bundler/gems/spring-d1ae63061326/lib/spring/test/acceptance_test.rb:172:in `block in <class:AcceptanceTest>'
...
52 runs, 157 assertions, 0 failures, 1 errors, 0 skips
I tried again, and I got same error for Ruby 2.2.7 and 2.4.1. It looks the issues that sometimes happens. https://travis-ci.org/jonleighton/spring-watcher-listen/builds/225307729
@jonleighton Finally I passed all the tests.
I did below things to prevent the error Errno::EBADF: Bad file descriptor
that are sometimes happened.
I thought the solution was saving the resource to build.
Rakefile
to run unit and acceptance test sequentially.
(Maybe the most important factor)I was inspired from rails/spring
for the .travis.yml
and Rakefile
.
https://github.com/rails/spring/blob/master/.travis.yml
https://github.com/rails/spring/blob/master/Rakefile
Could you check and merge it? Thanks.
The result of task list is like this.
$ bundle exec rake -T
rake build # Build spring-watcher-listen-2.0.1.gem into the pkg directory
rake clean # Remove any temporary products
rake clobber # Remove any generated files
rake install # Build and install spring-watcher-listen-2.0.1.gem into system gems
rake install:local # Build and install spring-watcher-listen-2.0.1.gem into system gem...
rake release[remote] # Create tag v2.0.1 and build and push spring-watcher-listen-2.0.1....
rake test # Run tests
rake test:acceptance # Run tests for acceptance
rake test:unit # Run tests for unit
The test passed. Could you merge it? Thanks.
Thanks
@jonleighton thanks for the merging.
I updated Rubies to latest version. I also added
ruby-head
asallow_failures
.I think this is useful. Because we can support the next version Ruby as faster.
We can see this kind of logic in
rails
,rspec
andcucumber
and etc. https://github.com/rails/rails/blob/master/.travis.yml https://github.com/rspec/rspec-core/blob/master/.travis.yml https://github.com/cucumber/cucumber-ruby/blob/master/.travis.ymlIs it possible to merge?
Thanks.