search

rails / spring-watcher-listen

MIT License
64 stars 35 forks source link

Test suite si broken since Spring 2.1.0 #24

Closed voxik closed 2 years ago

voxik commented 3 years ago

The Spring 2.1.0 moved its testing bits out of lib into test directory [1], which breaks the test suite.

I was able to convince the test suite to run by having the Spring test suite at hand and these two simple changes:

sed -i '/spring\/test/ s/spring/support/' test/helper.rb
sed -i '/spring\/test/ s/^/#/' test/unit_test.rb

However, there remain one failure:

  1) Error:
ListenWatcherTest#test_add_directory_with_dangling_symlink:
NoMethodError: undefined method `check_stale' for #<Spring::Watcher::Listen:0x00007f355c0585a0>
    /builddir/build/BUILD/test/support/watcher_test.rb:189:in `block in <class:WatcherTest>'

It seems that the polling adapter support #check_stale method, which is, however, not part of the abstract interface.