rails / spring-watcher-listen

MIT License
64 stars 35 forks source link

support spring 4 #32

Closed fcheung closed 2 years ago

fcheung commented 2 years ago

This runs ok on my rails 6.1 apps with spring 4. Main cause of incompatibility was https://github.com/rails/spring/commit/7f4ddf9f280012e2af7a43f8a96b310a4d26235a#diff-8079047024eafaf078a5ec33c6e989295d077b3306c92c168a4cc043c9f780b2

There is one remaining failing test - this comes from https://github.com/rails/spring/blob/main/test/support/watcher_test.rb#L192

As far as I can tell this has probably always failed: this expects a watcher to have a check_stale method which spring-watcher-listen has never had. This feels like a spec of the polling implementation rather than a spec of the high level functionality - check_stale in poller.rb is the main 'walk all the files and check their mtime', which is a concept that just doesn't existing in spring-watcher-listen.

toobulkeh commented 2 years ago

Note that this drops support for Ruby < 2.7.3 and Spring < 4.0 (was that required?)

fcheung commented 2 years ago

It does indeed. Spring 4 also drops support for older rubies which is why I made that change.

Lokideos commented 2 years ago

@fcheung @toobulkeh Hello, gentlemen! Any plans regarding merging this PR into master?

fcheung commented 2 years ago

I’ve bee. Using this without issue - not sure who is a maintainer here

der-flo commented 2 years ago

I’ve bee. Using this without issue - not sure who is a maintainer here

@rafaelfranca Can you clarify the situation as the last one who committed to the gem? @jonleighton Can you clarify as original maintainer?

May we help with anything?

tmoney100 commented 2 years ago

Any way to get this merged in? Please. Thank you.

afdev82 commented 2 years ago

any news?

kemalmutlu commented 2 years ago

any news? @jonleighton

thilonel commented 2 years ago

@rafaelfranca @e2 @jonleighton could someone please merge this and release a new version? 🙏

williantenfen commented 2 years ago

@rafaelfranca alguma news? 🇧🇷