search

rails / spring

Rails application preloader
MIT License
2.81k stars 341 forks source link

DEPRECATION WARNING: Using a :default format for Time#to_s is depreca… #701

Closed moskvin closed 1 year ago

moskvin commented 1 year ago

…ted. Please use Time#to_fs instead.

leonid-shevtsov commented 1 year ago

IMO it makes more sense to do Time.now.iso8601; that's what the default format for to_s was, and it works well for log timestamps. And is more explicit.

matthewd commented 1 year ago

It's not this library's job to protect itself against monkey-patched core methods.

Correspondingly, if someone wants to monkey-patch to_s (the effective result of configuring a :default format), they should do that directly -- at which point this call will be duly affected just like any other.

leonid-shevtsov commented 1 year ago

It's not this library's job to protect itself against monkey-patched core methods.

This is a Rails 7 issue, how is it not Spring's job to be compatible with Rails?