rails / spring

Rails application preloader
MIT License
2.81k stars 341 forks source link

Drop dependency on mutex_m #703

Closed byroot closed 1 year ago

byroot commented 1 year ago

It doesn't really save much effort, and it's being extracted as a gem which cause issues for projects like spring that often are loaded before bundler.

Reported by @tisba

tisba commented 1 year ago

Awesome turnaround time, thanks a lot @byroot! 🥳

fschwahn commented 1 year ago

@byroot This breaks eg. spring-watcher-listen (see https://github.com/rails/spring-watcher-listen/issues/36), as it depends on the synchronize method. Possibly there are other dependencies affected by this.

Maybe instead of patching all dependencies which depend on this synchronize method could be added back to Abstract?

def synchronize(&block)
  @mutex.synchronize(&block(
end
byroot commented 1 year ago

Thanks for the ping.

fschwahn commented 1 year ago

Thank you for the quick turnaround 👍