search

rails / sprockets

Rack-based asset packaging system
MIT License
947 stars 788 forks source link

Better ERB keyword argument check #719

Closed casperisfine closed 2 years ago

casperisfine commented 2 years ago

Later on later versions ERB.version has no prefix:

$ ruby -v
ruby 3.1.0dev (2021-10-06T06:42:37Z master d53493715c) [x86_64-darwin20]
$ ruby -rerb -e 'p ERB.version'
"2.2.3"

So It's better to check what the method parameters are like.

yahonda commented 2 years ago

It would be very helpful if newer version of sprockets is released because Ruby 3.2.0dev finally removes positional arguments via https://github.com/ruby/ruby/commit/d12a08abb5fd1412d59094a953899bbd8a64ac88 and Rails CI is failing https://buildkite.com/rails/rails/builds/84046#9e481c18-b4a7-43fc-865d-4835b863ce40