rails / tailwindcss-rails

Other
1.39k stars 170 forks source link

Handle `tailwindcss:watch[always]` #262

Closed GoodForOneFare closed 1 year ago

GoodForOneFare commented 1 year ago

Passes -w always along to tailwindcss, which keeps the watch going even if stdin closes (https://github.com/tailwindlabs/tailwindcss/pull/9966).

rafaelfranca commented 1 year ago

Any reason why this can't be the default of tailwindcss:watch?

GoodForOneFare commented 1 year ago

@rafaelfranca the default behaviour is IMO better. In most environments, the default mode cleans up its own orphaned processes. The tailwind developers added --watch always with reluctance, and I think it's only useful for niche environments where developers don't have control of their Docker config.

flavorjones commented 1 year ago

@GoodForOneFare I could use your help to understand what we should add to the "troubleshooting" section to help users understand when to use this feature. What will people see if they need to set this?

flavorjones commented 1 year ago

See https://github.com/rails/tailwindcss-rails/commit/e665b097ae51e4e4d388370352a6390d41e685fd