search

rails / tailwindcss-rails

Other
1.39k stars 170 forks source link

fix: mailer generation with namespaces #308

Closed flavorjones closed 8 months ago

flavorjones commented 8 months ago

Fixes #272

I'm a little confused why this gem implements mailer generation if it's just a copy-paste from rails, but if we're going to do it, then we need the layout files as well.

cc @dixpac from #84

dixpac commented 8 months ago

👍

@flavorjones @dhh I wish we could just make one of the next engine versions railties >= 7, initially I had to jump through all kind of hoops with the generator just to make it work with both 6 and 7, because there was a "large" change in rails 7 scaffolds.

flavorjones commented 8 months ago

@dixpac Thanks for the :eyes: and the note about Rails 7 generators (which I wasn't aware of).

:thinking: I don't think we're currently running CI with Rails 6.x, do you think we should do that unless and until we pin to >= 7?

dixpac commented 8 months ago

🤔 I don't think we're currently running CI with Rails 6.x, do you think we should do that unless and until we pin to >= 7?

Good question, I guess we should :)

@dixpac Thanks for the 👀 and the note about Rails 7 generators (which I wasn't aware of).

I basically had to copy rails 7 default generator and call it tailwindcss generator, so anyone that is using rails 6 can have rails 7 like behavior with divs and partials instead of old html tables that were used in rails 6.

flavorjones commented 8 months ago

🤔 I don't think we're currently running CI with Rails 6.x, do you think we should do that unless and until we pin to >= 7?

Good question, I guess we should :)

I'll take care of it.