Tailwind scaffold template is out of sync with rails/rails ERB scaffold template

rails / tailwindcss-rails

Other

1.37k stars 165 forks source link

Tailwind scaffold template is out of sync with rails/rails ERB scaffold template #341

Closed yshmarov closed 2 months ago

yshmarov commented 4 months ago

https://github.com/rails/tailwindcss-rails/blob/main/lib/generators/tailwindcss/scaffold/templates/index.html.erb.tt is out of sync with https://github.com/rails/rails/blob/main/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb.tt, namely it's missing the <% content_for :title, "New event" %>

Should template files be kept in sync (except the tailwind classes)?

flavorjones commented 4 months ago

@yshmarov Thanks for spotting that! If you have the time to submit a PR I would be happy to merge it. If not, please let me know and I can fix it later this week.

flavorjones commented 3 months ago

Looking at the changes to rails templates since 2021, there are a few changes that should probably be carried over to this gem. I'm not going to do this work, but would welcome anyone from the community who would like to submit a PR.

I think the set of changes that should be looked at is limited to:

rails/rails#43611 (rails/rails@6cd75a42)
rails/rails#43846 (rails/rails@1c390905)
rails/rails#43880 (rails/rails@ea15f8e6)
rails/rails#49702 (rails/rails@42ca4de4)