search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.14k stars 552 forks source link

Errors printed during tests, but tests pass. #265

Open ahawkins opened 12 years ago

ahawkins commented 12 years ago

Here is the output from running the tests against current master:

adam at mba : ~/projects/thor[master] % git rev-parse --short HEAD
b75e0ac
adam at mba : ~/projects/thor[master] % rspec   
................................................................................................................................thor hidden requires at least 1 argument: "thor my_script:hidden TYPE".
thor hidden requires at least 1 argument: "thor my_script:hidden TYPE".
....................................................................................................................................thor two requires at least 0 argument: "thor a:two".
..........................................................................................................................................................................................................................................................................................................................................................

Finished in 1.54 seconds
606 examples, 0 failures

Randomized with seed 23201

Coverage report generated for RSpec to /Users/adam/projects/thor/coverage. 4461 / 4626 LOC (96.43%) covered.
adam at mba : ~/projects/thor[master] %

Should the stderr messages be there or not? The tests pass so I think all is good. Some investigation may be required.

wycats commented 12 years ago

You can just capture the stderr if it's acceptable but not tested.