Closed deivid-rodriguez closed 4 years ago
When dropping 1.8.7 support, I blindly removed this check, because the comment above it suggested that it was 1.8.7-specific.
1.8.7
However, the check is also needed for rb-readline, the default readline implementation on modern rubies under Windows. See https://github.com/ConnorAtherton/rb-readline/blob/9fba246073f78831b7c7129c76cc07d8476a8892/lib/readline.rb#L91-L97.
rb-readline
So, I'm restoring the check, and the specs changes that I included in the 1.8.7 support drop commit to get specs passing.
When dropping
1.8.7support, I blindly removed this check, because the comment above it suggested that it was 1.8.7-specific.However, the check is also needed for
rb-readline, the default readline implementation on modern rubies under Windows. See https://github.com/ConnorAtherton/rb-readline/blob/9fba246073f78831b7c7129c76cc07d8476a8892/lib/readline.rb#L91-L97.So, I'm restoring the check, and the specs changes that I included in the 1.8.7 support drop commit to get specs passing.