Closed nicolas-brousse closed 1 year ago
Good point. Let's remove that warning. Can you open a PR?
Yes, I can take a look in the following days.
I opened a PR :)
Let me know if you want some changes on my PR 🙂. I may have some time for the following weeks
Hi guys! This is a warning that we're running across as well for https://github.com/solidusio/solidus_dev_support. Not a big deal, but it is a bit jarring for users, as it looks like something went wrong. Glad to see there's a PR open, if there's anything I can do to help here please let me know :)
I think here is another false positive for this warning: https://github.com/stimulusreflex/stimulus_reflex/issues/118
If I use
append_file
orinsert_into_file
in a generator, and I execute generator twice, thenFile unchanged! The supplied flag value not found!
warning is printed.Is this the expected behavior. It sounds curious to me. Why doesn't it print
identical
orunchanged
without warning, sincecontent.include?(replacement)
returns true?Related to #683