rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.12k stars 553 forks source link

Don't use ANSI colors when terminal is dumb #710

Closed tpope closed 4 years ago

tpope commented 4 years ago

🌈

It is possible for stdout to be a tty and still not support ANSI colors. One example of this is the :! command in GVim or MacVim. I had long assumed that the only way to reliably detect this was to introduce a heavyweight dependency such as libncurses, but recently I learned that checking that the environment variable TERM is set to a value other than dumb is largely sufficient. This is what Git does, for example:

https://github.com/git/git/blob/0d0ac3826a3bbb9247e39e12623bbcfdd722f24c/editor.c#L11-L15

This patch implements identical behavior for Thor.