rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.12k stars 553 forks source link

🌈 Fix readline specs #717

Closed bpo closed 4 years ago

bpo commented 4 years ago

An error was introduced in commit 7061b06fd87dc8b952f9072507ee991ee0a0858e where readline specs fail because require "readline" is called after the spec has established a mock ::Readline. Prior to that change require "readline" was always only called once.

This patch:

This error wasn't caught by CI due to the bundler cache. You can see the failure caused by the earlier change by removing the Bundler cache from Travis