search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.12k stars 553 forks source link

Newly added quiet option in say shell is a breaking change #751

Open xtreme-shane-lattanzio opened 3 years ago

xtreme-shane-lattanzio commented 3 years ago

Hey! I am from the LicenseFinder team that heavily relies on thor. I tried to track down why we are no longer getting output in newer versions of thor and found that this commit is a breaking change.

We used the quiet option to suppress basically everything except what is in say. With this, we are now getting empty string output. Was this intentional? Is there some other recommended way we should be outputting the results? We can try to change the way we do things on our end but wanted to ping here to figure out the reasoning for this change. Thanks!

rafaelfranca commented 3 years ago

Yes. It was deliberate and not considered a breaking change, since the fact that say was not respecting quiet was a bug. We could be adding a new option to force say to print. Do you want to open a PR?