search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.12k stars 552 forks source link

Support latest did_you_mean #761

Closed deivid-rodriguez closed 2 years ago

deivid-rodriguez commented 2 years ago

Using DidYouMean::SPELL_CHECKERS.merge! has been deprecated.

Since this new version will be included with Ruby 3.1, I'm looking into supporting it without warnings.

deivid-rodriguez commented 2 years ago

This breaks tests, so no good.

deivid-rodriguez commented 2 years ago

Errors were caused by my stupidity, hopefully it's all good now :)

yuki24 commented 2 years ago

Thanks @deivid-rodriguez for wrapping this up. I happen to have sent the exact same PR as yours so I just closed mine. This change looks good to me from the did_you_mean side.

deivid-rodriguez commented 2 years ago

No problem @yuki24!

dorner commented 2 years ago

LGTM! @rafaelfranca ?

emmahsax commented 2 years ago

@rafaelfranca Any updates on this? Would be super helpful to get this out so that all of our warning messages quiet up 😄 . Thank you!

zchrb commented 2 years ago

Echoing @emmahsax's comment. Wondering when this will be merged since all checks have passed 🤔

ojab commented 2 years ago

Oh, c'mon it's holiday time and you're pinging ppl about deprecation warnings https://github.com/rails/rails/issues/43998#issuecomment-1004281302

emmahsax commented 2 years ago

@ojab I asked kindly. There are many times where I've felt bad for pinging people, but the truth is that pinging people to remind them or to place it higher in their notifications list is very different from expecting them to do something right away. People forget things all the time and need to be reminded, and that's okay.

I asked if there were any updates. A question that would accept an answer such as "I'm on vacation for the next week. I have plans to do it next Monday!". Which is very different from "Please do this today, because you can't possibly have anything better to do".

Lastly, the comment you linked to mentions the last two weeks of the year, and that time is now over. I don't feel like I am interrupting somebody's life because the person that I pinged is the same person that posted that comment you linked to four hours ago (AKA they were looking at their computer at some point today). I was polite, and asked them for updates, not to do it right away.

ctilley83 commented 2 years ago

Oh, c'mon it's holiday time and you're pinging ppl about deprecation warnings rails/rails#43998 (comment)

Happy Holidays. For me it wasn't a warning and wouldn't allow me to start the dev server on rails 7.0