search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.11k stars 552 forks source link

Use DidYouMean.correct_error for better Ractor support #762

Closed yuki24 closed 2 years ago

yuki24 commented 2 years ago

I was working on better Ractor support for DidYouMean for the last few days. As part of that I had to deprecate the direct access to DidYouMean::SPELL_CHECKERS due to the necessity to maintain shareable objects within the dependency. From the next version the DidYouMean.correct_error method should be used as a replacement. This PR replaces the old API with the new one and should fix the build failures in the upstream Ruby.

Let me know if there is anything I can do to get this change in.

yuki24 commented 2 years ago

Ah, this is the exact same change as #761. Closing.