rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.11k stars 552 forks source link

Repeatable hash type flags bugfix. #769

Open patrick-motard opened 2 years ago

patrick-motard commented 2 years ago

They treated like every other type now. Instead of merging each key/val into a hash, each flag is treated like it's own hash that should be put into an array.

fixes #768

:rainbow:

dorner commented 2 years ago

Nice! Looks good to me - @rafaelfranca ?

patrick-motard commented 2 years ago

bump

wwwbruno commented 1 year ago

Any updates on this fix? I faced this issue and this solves my problem.

rafaelfranca commented 1 year ago

This is a change in the behavior and people might be expecting the option to merge instead of having two hashes. I don't think I can accept this change as is. I totally get the current behavior isn't what you want, but we can't assume it is broken and don't have a way to have it.

I'd accept an option that would allow the behavior you want though.