Switch hash from MD5 to SHA256

rails / thor

Thor is a toolkit for building powerful command-line interfaces.

http://whatisthor.com/

MIT License

5.12k stars 552 forks source link

Switch hash from MD5 to SHA256 #785

Closed stanhu closed 2 years ago

stanhu commented 2 years ago

On FIPS-compliant systems (http://en.wikipedia.org/wiki/FIPS_140), MD5 cannot be used. Switch to SHA256 instead.

However, this change does not keep backward compatibility with systems with already-installed Thor recipes.

Closes #287

stanhu commented 2 years ago

Some tests will be fixed by https://github.com/rails/thor/pull/771.

dorner commented 2 years ago

Yeah I'm not sure this is actually a backwards compatibility issue. Looks like it just affects what filename Thor uses to save its config? Looks like it'll just save with the new filename if it can't find the old one. I'm OK with this @rafaelfranca

stanhu commented 2 years ago

@rafaelfranca Would you mind reviewing here? We'd like to drop uses of MD5 in our code base ASAP.

stanhu commented 2 years ago

@rafaelfranca Could I trouble you to release a new version with this? Thanks so much.