search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.11k stars 552 forks source link

Update thor's implementation of the NO_COLOR spec to match the updated specification. #795

Closed coderjoe closed 1 year ago

coderjoe commented 1 year ago

As discussed in this comment thread on the original commit the NO_COLOR specification has been silently changed. The new specification expects that NO_COLOR will only be respected if set to a non-empty value.

Given the arguments in the NO_COLOR project discussion it's probably worth updating it here.

I'll submit a PR for this issue shortly.