search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.11k stars 552 forks source link

Respect the updated NO_COLOR specification #796

Closed coderjoe closed 1 year ago

coderjoe commented 1 year ago

Since implementation the NO_COLOR specification has changed. Previously if NO_COLOR was set in the environment it should be respected regardless of value. In the new updated specification NO_COLOR should only be respected if set to any non-empty string.

See this comment thread on the original commit for more information. https://github.com/rails/thor/commit/21e65684432c0fcc975c1d6fda497da24149f763#r80414525

Fixes #795

rafaelfranca commented 1 year ago

I think it is fine to merge this. I'll make sure this is included in the changelog.

coderjoe commented 1 year ago

Thank you very much for your help @rafaelfranca :)