search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.11k stars 552 forks source link

Prefer to use URI.open and File.open instead of Kernel.open #802

Closed hsbt closed 1 year ago

hsbt commented 1 year ago

👋 CodeQL detects "Use of Kernel.open or IO.read with a non-constant value" warnings in https://github.com/ruby/ruby. I hope to suppress them.

deivid-rodriguez commented 1 year ago

I fixed the URI.open ones similarly at #787. Not yet attended unfortunately!

hsbt commented 1 year ago

Oh! Thanks to share it.

deivid-rodriguez commented 1 year ago

Should we enable Security/Open in RuboCop configuration file too?

hsbt commented 1 year ago

👍 or add CodeQL actions.

deivid-rodriguez commented 1 year ago

That too, just thought of RuboCop since it's already used.

rafaelfranca commented 1 year ago

Can you please rebase this PR?

hsbt commented 1 year ago

@rafaelfranca done 🚀

hsbt commented 1 year ago

Thanks @rafaelfranca ❤️