Default value not printed in help if option type boolean and default value is false

rails / thor

Thor is a toolkit for building powerful command-line interfaces.

http://whatisthor.com/

MIT License

5.14k stars 553 forks source link

Default value not printed in help if option type boolean and default value is false #819

Closed hadmut closed 1 year ago

hadmut commented 1 year ago

Hi,

usually the help output generated by a thor app lists the options for the class and the actions, and shows the default value if a default value is set.

But for method_option :save, type: :boolean, desc: "save file" , default: false

the default value is printed only of it is true, not false. (Thor 1.2.1)

regards

p8 commented 1 year ago

@hadmut this can now be closed, right?

hadmut commented 1 year ago

I didn't find the time to verify it yet, but I do fully trust you.