search

rails / thor

Thor is a toolkit for building powerful command-line interfaces.
http://whatisthor.com/
MIT License
5.11k stars 552 forks source link

Avoid loading bundler 2.4.22 that vendorizes thor 1.3.0 #869

Closed amatsuda closed 4 months ago

amatsuda commented 5 months ago

when thor 1.3.0 is vendorized, lcs_diff.rb emits method redefinition warnings as follows:

.../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:6: warning: method redefined; discarding old show_diff .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:6: warning: previous definition of show_diff was here .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:21: warning: method redefined; discarding old output_diff_line .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:21: warning: previous definition of output_diff_line was here .../src/github.com/rails/thor/lib/thor/shell/lcs_diff.rb:37: warning: method redefined; discarding old diff_lcs_loaded? .../.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/bundler-2.4.22/lib/bundler/vendor/thor/lib/thor/shell/lcs_diff.rb:37: warning: previous definition of diff_lcs_loaded? was here

amatsuda commented 5 months ago

I forgot to describe what this patch solves. This patch fixes currently failing CI on Ruby 2.7 https://github.com/rails/thor/actions/runs/7106766044/job/19346865013

amatsuda commented 4 months ago

🤦