Fixes #3208 Rake tasks don't show log out put

rails / webpacker

Use Webpack to manage app-like JavaScript modules in Rails

MIT License

5.31k stars 1.47k forks source link

Closed joker-777 closed 2 years ago

joker-777 commented 2 years ago

you have to assign Logger.new(STDOUT) instead of ActiveSupport::Logger.new(STDOUT) to Webpacker.logger

justin808 commented 2 years ago

If the intent of the code is to ALWAYS go to STDOUT, then the changes suggested look fine.

@guillaumebriday any reason not to merge?

guillaumebriday commented 2 years ago

Great!

crawler commented 2 years ago

@joker-777 @justin808 don't you experience an error due to missing "tagged" method for the Logger.new(STDOUT) after this change?

joker-777 commented 2 years ago

@justin808 @guillaumebriday @crawler I don't think this change hasn't been released yet.

justin808 commented 2 years ago

@joker-777 Should be in v.6.0.0.rc.13 of https://github.com/shakacode/shakapacker/.

joker-777 commented 2 years ago

@justin808 Sorry, for not being clear enough. I was talking about 5.x.

justin808 commented 2 years ago

Your PR went to master. I think only security fixes will go to 5.x and below.

crawler commented 2 years ago

@justin808 a simple assets:precompile fails for me on this line: https://github.com/rails/webpacker/blob/b8a01d7a880e0c34473a8c8490b3dc730e3f3586/lib/webpacker/manifest.rb#L58 Am I missing something or is this task not covered by any test?

justin808 commented 2 years ago

What versions of rails and webpacker are you using?