search

rails / webpacker

Use Webpack to manage app-like JavaScript modules in Rails
MIT License
5.31k stars 1.47k forks source link

Make watched_files_digest thread safe #3233

Closed justin808 closed 2 years ago

justin808 commented 2 years ago

Based on PR https://github.com/rails/webpacker/pull/3218

I detected the issue with #3218 when I noticed the timing was impossibly fast

Note, this method is still crazy slow on big projects.

On a big project: user system total real 1.985895 2.741152 4.727047 ( 9.214857)

justin808 commented 2 years ago

We should run the docs through Grammarly! Thanks for the typo catch, @guillaumebriday!

justin808 commented 2 years ago

Thanks, @nguyenthetoan. I applied your changes.

justin808 commented 2 years ago

Merged in https://github.com/shakacode/webpackr/pull/6.