Upgrading workflows - Githubissues

rails / webpacker

Use Webpack to manage app-like JavaScript modules in Rails

MIT License

5.31k stars 1.47k forks source link

Upgrading workflows #3249

Closed guillaumebriday closed 2 years ago

guillaumebriday commented 2 years ago

Updating the CI with the current LTS of Node
Cleaning workflows
Testing against new versions of Rails and Ruby

aried3r commented 2 years ago

Cleanup looks good!

But I don't think linting with multiple node and Ruby versions makes sense. RuboCop should yield the same result with any Ruby version. Currently it should check with the Ruby 2.7 parser because of this line:

https://github.com/rails/webpacker/blob/550c53eb7816140a24b3af9691fbbdf23f24a563/.rubocop.yml#L3

Same should go for JS linting. WDYT?