search

rails / webpacker

Use Webpack to manage app-like JavaScript modules in Rails
MIT License
5.31k stars 1.47k forks source link

Backport #3250 to 5-x-stable branch #3306

Closed amatsuda closed 1 year ago

amatsuda commented 1 year ago

Currently released stable version of webpacker (5.4.3) does not work on the newest stable Ruby (3.2.0) because webpacker 5.4.3 includes Dir.exists? and File.exists? that were removed in Ruby 3.2.

Hence, the current situation is that Rails 6.1 users cannot upgrade to Ruby 3.2 because there's no webpacker that supports that versions stack. We could solve this situation by backporting a single commit from #3250.

Please consider merging this and cutting the version 5.4.4 release from 5-x-stable branch. Then probably people would stop complaining to the Ruby-core on the Ruby BTS about this error from webpacker... https://bugs.ruby-lang.org/issues/19352

Closes #3299

dlupu commented 1 year ago

💯 would appreciate this to be done soon.

amatsuda commented 1 year ago

@byroot Thank you for working on this!

dlupu commented 1 year ago

@byroot, thanks for backporting this and releasing version 5.4.4. Any chance you can do something about https://github.com/rails/webpacker/issues/3308 ?

byroot commented 1 year ago

Thanks for letting me know. Unfortunately I don't have an NPM account, hence not the ownership of the package. I relayed the issue to rails-core.

byroot commented 1 year ago

@dhh released the 5.4.4 a few minutes ago: https://www.npmjs.com/package/@rails/webpacker so you should be good now.