railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.9k stars 2.26k forks source link

Add Sub-sections Modal_Create and Modal_Update for Modal #1161

Open zelid opened 12 years ago

zelid commented 12 years ago

Is it possible to add Create and Update sub-sections to Modal (https://github.com/sferik/rails_admin/blob/master/lib/rails_admin/config/sections/modal.rb) section?

Some times AJAX popup should include different fields for create and update actions, just like Edit section could be overridden with Create and Update sections.

mshibuya commented 12 years ago

No, not possible at this time. But sounds reasonable.

ehoch commented 12 years ago

I suppose since I added the Modal configuration I could take this on. So you're proposing a ModalCreate and ModalEdit that inherit from Modal?

Hey dev team, is there something we're adding for JS integration tests?

bbenezech commented 12 years ago

Not at the present time...

I wish we could have :

and get rid of all the slow, ugly and unmaintainable integration specs, especially the part about the config options... (I'm moving it to unit specs, the other part would be cucumber stories).

Optionally, we would have a JS unit coverage, but I'm probably not the man for the task.

@mshibuya what do you think?

mshibuya commented 12 years ago

@bbenezech of course we definitely need it. Besides capybara-webkit, PhantomJS capybara driver poltergeist will be a good candidate for headless JS-enabled testing, too.

And for JS unit testing, jasminerice or guard-jasmine(headless JS testing!) looks nice. I'll take a look on them when I have time.

gunn commented 12 years ago

Also have a look at evergreen for JS testing with jasmine in-browser and headlessly. I'm using it and it works very well although I hadn't seen @mshibuya's links