railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.88k stars 2.25k forks source link

Port project Javascript from Prototype to jQuery #268

Closed kaapa closed 13 years ago

kaapa commented 13 years ago

For now this is just a placeholder. I'll write information regarding this topic in the following days and push a feature branch for completing the task.

kaapa commented 13 years ago

Branch for the port.

What has been done:

What's been done (Feb 4th update):

What's been done (Feb 17th update):

What's been done (Mar 11th update):

What's been done (Mar 14th update):

What's missing:

Postponed after merge:

kaapa commented 13 years ago

I'd like to invite everyone to give a test for the jQuery branch of RailsAdmin and report any issues in this thread. All help would be very much appreciated as some manual QA is required before I feel confident enough to merge the branch to master.

sferik commented 13 years ago

I spent this morning testing the jQuery branch and believe it is ready to be merged into master as soon as the last know bug is resolved (list views next/previous column set links).

Fantastic work Petteri!

aroop commented 13 years ago

Everything seems to be working great in my testing. Except for I don't see the ""Records" column being populated in Dashboard page.

Thanks for the excellent work

kaapa commented 13 years ago

Thank you for the compliments and the bug report!

The records bars are now populated again (see 837270dddd6c291a4e8987e32b39d53d8a5488fd). I somehow had managed to drop the css definition that makes the bars visible.

kaapa commented 13 years ago

Oh and forgot to report that the column set links bug has been resolved by 7f9450e9a53e20233a97e75978d2ebf902e7f335.

I think though, that we shouldn't merge until the Labelable refactoring (a8f20fa82ec0688a29191ccdcf8ba699feb3af31) has been addressed.

aroop commented 13 years ago

I have tested the record bar functionality and its working good now. I will keep testing for more issues.

aroop commented 13 years ago
navigation do
  visible false
end

throws an error at server start up and hide_from_navigation does not have any effect in jQuery branch. Both of them seems be working fine in the master

kaapa commented 13 years ago

That is in fact intentional, see 2253729ea063d523d7c528b26870a2a5c89a7f8f.

aroop commented 13 years ago

Oops sorry missed that

kaapa commented 13 years ago

No probs, I really appreciate the effort you're putting into testing the branch. It's a massive help! :)

sferik commented 13 years ago

Okay, I reverted a8f20fa82ec0688a29191ccdcf8ba699feb3af31. Let's merge this thing!

kaapa commented 13 years ago

Erik, will you do the merge or shall I?

I have one last minute minor fix to include (filtering multiselect has hardcoded word "teams" instead of the associated models label), although I can push it directly to master after merge as well.

sferik commented 13 years ago

I'll leave the honor of merging to you!

Feel fre to fix up the hardcoded multiselect on either side of the merge.

kaapa commented 13 years ago

Merged, happy times! :)

JDutil commented 13 years ago

Great work guys! I've been using the jquery branch the last week or so, and I'm glad to see it in master now.