dedman
commented
6 years ago @romikoops I'm seeing a similar issue too I think, intermittently @bindings is nil. Did you work out a fix?
Closed romikoops closed 5 years ago
dedman
commented
6 years ago @romikoops I'm seeing a similar issue too I think, intermittently @bindings is nil. Did you work out a fix?
romikoops
commented
6 years ago @dedman Hello, I have not worked on that yet. To fix that, it is required to refresh knowledge about tread safe coding, learn how Puma deals with thread and at the end to understand how to fix it in Rails admin. I expected to have some help from community who knows it better than me. Anyway, I can not wait and will start to work on that at the end of this week.
romikoops
commented
6 years ago I just moved to Thin web server and problem has gone. I will not close the issue, probably it will be fixed by somebody.
thechrisoshow
commented
6 years ago I'm seeing this issue as well using Puma. Any suggestions on how to fix this without moving to Thin?
CodeMonkeySteve
commented
6 years ago I'm having the same problem with Thin and EM-Synchrony (which uses Fibers instead of Threads, but suffers from the same RailsAdmin design problem). I hacked together a solution that monkey-patches Proxyable to use Thread/Fiber-local variables. This seems to work in my case (with RailsAdmin v0.7), and should also work in threaded environments (YMMV):
require 'rails_admin/config/proxyable'
module RailsAdmin::Config::Proxyable
def bindings
Thread.current[:ra_bindings] ||= {}
Thread.current[:ra_bindings][self]
end
def bindings=(new_bindings)
Thread.current[:ra_bindings] ||= {}
Thread.current[:ra_bindings][self] = new_bindings
end
class Proxy
def method_missing(name, *args, &block)
if @object.respond_to?(name)
reset = @object.bindings
begin
@object.bindings = @bindings
response = @object.__send__(name, *args, &block)
ensure
@object.bindings = reset
end
response
else
super(name, *args, &block)
end
end
end
end
robwise
commented
5 years ago Is anyone else having this issue? I am, and it's strange to me that such a popular gem would have this issue with Puma (which is also very popular) yet not many others are encountering this?
austinbachman
commented
5 years ago I am seeing something potentially similar on Puma as well, where the value of bindings[:object] within a nested form will sometimes evaluate to the parent model instead of the child.
Babbz75
commented
3 years ago @mshibuya was this fix put into a released version of the gem?
mshibuya
commented
3 years ago Yes, it's there since the 2.0.0 release.
I use rails 5.1 application with Puma as a web server by default. I have loosing original value of @bindings on opening for edit an entity with big amount of associated records (it is core feature of my app). I tried to debug and see the problem happens here https://github.com/sferik/rails_admin/blob/master/lib/rails_admin/config/proxyable/proxy.rb#L22
When I start my web application with single thread, I never had exception
When I start it by default with 5 threads, then it randomly generates this error: