search

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.89k stars 2.26k forks source link

Rails Admin should be prettier #317

Closed gunn closed 13 years ago

gunn commented 13 years ago

Update: See the new pretty rails_admin live here: http://rails-admin.heroku.com See the code here: https://github.com/gunn/rails_admin/tree/activo

...

I've put up a repo with some mockups at: https://github.com/gunn/rails_admin-prototypes/

The idea would be to base this on the current jquery branch, and modify the markup to be consistent with what the web-app-theme project provides. This would make us compatible with a few nice css / js themes in addition to the one shown in my mockups.

What do people think?

bbenezech commented 13 years ago

@gunn Ah ok, I see. And is it doable to have a theme switcher? And refactor current theme to be compatible with new markup?

gunn commented 13 years ago

@drewda yep, some help would be great. @kaapa's done some more on this too - see gunn/rails_admin#37

By they way I've been using the activo branch in production projects for a few weeks now and it's working very well.

gunn commented 13 years ago

@bbenezech yes definitely doable (in JS or rails), I've kept all the activo stuff separate, although some files e.g. list.css may have some styles written with activo in mind. The current look could be applied closely (although probably not identically without a lot of effort) to the new markup. The new markup is cleaner, more semantic, and has more hooks for styling.

bbenezech commented 13 years ago

@gunn Thanks, that's awesome.

drewda commented 13 years ago

@gunn sure, I'll see what I can do.

soulnafein commented 13 years ago

How can I update en existing rails_admin installation to use the activo branch? Just changing the dependency in the Gemfile doesn't work (the style changes but it's all fucked up.

gunn commented 13 years ago

Hi @soulnafein changing the Gemfile is all you should need to do. Perhaps gem "rails_admin", git: "git://github.com/gunn/rails_admin.git", branch: "activo", ref: "b6386f7a" as the HEAD is a bit unpolished right now.

What are the problems specifically? Were you sure to restart rails? Could you have some outdated rails_admin static assets in your public directory (perhaps from running rake rails_admin:copy_assets)?

gunn commented 13 years ago

And merged! See #477.

kaylarose commented 13 years ago

@gunn Nice job!

gunn commented 13 years ago

Thanks @kaylarose and everyone who helped with this.

soulnafein commented 13 years ago

I've updated my installation with the new master. It's fine. What I had to do is call again the rails_admin:install command. Without that I wouldn't get the right style.

Anyway I've noticed a problem on Firefox 4 Ubuntu 11.04 (at least in my installation). When I apply a filter to a list of models, the filter appear without a background and it looks nasty :) Is it that a known issue?

bbenezech commented 13 years ago

Please refer to #484

evanrmurphy commented 13 years ago

@soulnafein Thanks for that tip. The styling was suddenly all confused on my installation. After running rake rails_admin:install, things seem to be working with the new Activo styling.

ejmm320 commented 13 years ago

@gunn You did a excellent job with this, but now i'm working on Rails 3.1, so i'm not be able to use it.

Where can i find an update? Thanks.