Fix orderable multiselect buttons

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data

MIT License

7.88k stars 2.25k forks source link

Fix orderable multiselect buttons #3506

Closed aaronlifton closed 2 years ago

aaronlifton commented 2 years ago

The Up/Down buttons for a "sortable" multiselect have labels, while the Left/Right buttons do not. These labels are cut off by the multiselect box. This PR removes the labels and uses the regional text as a title on the button instead.

Before

After

coveralls commented 2 years ago

Coverage remained the same at 94.169% when pulling dc18dd6d22e0a59690674122d04e4c65761b92bb on aaronlifton:fix-orderable-multiselect-buttons into 42d668f004f5abd7b2c3a5d265dff8df6e45441a on railsadminteam:master.

mshibuya commented 2 years ago

Great catch, thanks!