railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.89k stars 2.26k forks source link

Fix dart sass 2.0 division deprecations #3544

Closed darrenterhune closed 2 years ago

darrenterhune commented 2 years ago

The src/rails_admin/styles/base/theming.scss used division calculations which causes deprecation warnings with dart sass >= 2.

The fontawesome-free version also has the same problem.

Using calc() around the division math fixes the issue in theming.scss Upgrading fontawesome-free to the latest version fixes their issues

https://github.com/sass/sass/issues/2565 https://github.com/sass/dart-sass/issues/663

For rails projects using sassc this is a problem. The app I currently work on is on most recent gems and packages for everything. We do a really good job at keeping everything up to date. Unfortunately these warnings have now turned into errors being raised in webpacker-dev-server.

I tested these changes by publishing my own npm package while pointing our Gemfile to my forked version.

If we could get a minor release with this and any other minor fixes that may be in that would be really appreciated 😄

coveralls commented 2 years ago

Coverage Status

Changes unknown when pulling f2df56088ff646e3819ae80c4f420febc50435f0 on darrenterhune:dart-sass-2-0-deprecated-calc-upgrade-fontawesome-free into on railsadminteam:master.

mshibuya commented 2 years ago

Nice fix! There are also vendorized css and fonts), to be used by Sprockets-only applications. Could you update them as well?

darrenterhune commented 2 years ago

@mshibuya yeah I can update those today 😄

wartron commented 2 years ago

Thanks for fixing this.

mshibuya commented 2 years ago

Thank you 🌟