railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.88k stars 2.25k forks source link

Sidebar inconsistencies with collapse behavior #3553

Closed codealchemy closed 1 year ago

codealchemy commented 1 year ago

Describe the bug

Side navigation with multiple groups (such as static links in addition to configured models) can move around depending on the state of a given dropdown within the side navigation.

Example using the dummy app from /spec ![collapse-nav-default](https://user-images.githubusercontent.com/4504083/193148921-c8412bda-f16c-4ee9-a0de-f4732cd41625.gif)

Reproduction steps

Start demo app, visit the dashboard.

Expected behavior

Side navigation width and group stacking to be static / consistent.

Additional context

Add any other context about the problem here.

Collapsable sidebar introduced in https://github.com/railsadminteam/rails_admin/commit/e8cb8edd39246bf75ed72295b7832faf5056367c

mshibuya commented 1 year ago

Sorry about this, it was broken by ef76fcea0b23aed04f6568448cd157ccc9ba30a0 and fixed in the master now.

codealchemy commented 1 year ago

Looks good, thanks!