railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.88k stars 2.25k forks source link

Sidebar Menu not wrapping horizontally after changes for Bootstrap 5.2 #3564

Closed jklimke closed 1 year ago

jklimke commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

Since the commit https://github.com/railsadminteam/rails_admin/commit/d7abba4e8a2e380b4d7f8fb3b37302300af63de5 the sidebar of rails_admin within my app is broken as it does not add scrolling but the ul list extends horizontally when all the models are extended (i.e., on load of the rails admin dashboard page).

This Image shows the effect.

image

when i remove the "flex-colum" class that was added in the mentioned commit all looks fine again.

image

Reproduction steps

Expected behavior

Sidebar show add vertical scrolling

Additional context

I use webpacker to bundle assets and stylesheets. i checked that bootstrap 5.2.2 was used in the rails admin bundle. The rest of my app is still using bootstrap 4.6 but that is not included in the rails_admin pack.

Add any other context about the problem here.

Any hints why this happens ?

mshibuya commented 1 year ago

That's my bad, fixed in the master branch 🙇