search

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.87k stars 2.25k forks source link

Remove support for end-of-life Ruby 2.6 #3584

Closed jdufresne closed 1 year ago

jdufresne commented 1 year ago

Ruby 2.6 has been EOL since 2022-04-12. It is no longer receiving security or bug fixes and its use is not supported. See: https://www.ruby-lang.org/en/downloads/branches/

Removing Ruby 2.6 will reduce the testing and maintenance required for this version. Workarounds can be removed. The RailsAdmin project can begin adopting newer Ruby coding conventions when convenient.

This removes jruby-9.3 from CI testing as that represents Ruby 2.6. jruby-9.4 was not added as that does not pass test suite.

coveralls commented 1 year ago

Coverage Status

Coverage: 95.626%. Remained the same when pulling a4732c3726ea5c72c51a4996c2a5ad4aea950098 on jdufresne:ruby-eol into 98213b7364e8e7eb1de146ed4cdbcfcd4d441510 on railsadminteam:master.

mshibuya commented 1 year ago

Thanks for the PR, but again this is the policy I have been using for supported Ruby/Rails versions. https://github.com/railsadminteam/rails_admin/pull/3430#issuecomment-982554274

And for this time, there appears to be no compelling reason to drop the 2.6 support. I agree that application developers should avoid using EOLed-Rubies, but this project is a library. We should be careful on dropping support for old versions, since if we go too strict users will suffer in a dependency hell (being stuck with contradicting requirements of their dependencies).

So my opinion is it's better to drop 2.6 support on the next major release (maybe on the release of Rails 8.0, unless no other major changes happen). What do you think about this?

jdufresne commented 1 year ago

So my opinion is it's better to drop 2.6 support on the next major release

Makes complete sense to me. Thanks.