Restore caching in RailsAdmin::Config::Model#excluded?

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data

MIT License

7.87k stars 2.25k forks source link

Restore caching in RailsAdmin::Config::Model#excluded? #3587

Closed jdufresne closed 1 year ago

jdufresne commented 1 year ago

Partially reverts 2fa86c361b88fbd4c36adaad60be2104e57d75f5. The commit introduced a regression such that RailsAdmin::Config::Model#excluded? stopped caching false values.

coveralls commented 1 year ago

Coverage: 95.911% (+0.001%) from 95.91% when pulling 856758a5b5c304acc333dd549c6ed5ff7fd71d92 on jdufresne:restore-caching into e8319bc5130c9fff31229827b5741a3707e6dc9d on railsadminteam:master.

mshibuya commented 1 year ago

Can this behavior tested in the spec, so we don't accidentally disable it again?

jdufresne commented 1 year ago

@mshibuya Good call. Amended an existing test in the latest push that demonstrates the caching.

mshibuya commented 1 year ago

Thank you 👍