railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.87k stars 2.25k forks source link

Fix image_html path #3602

Closed antontre1 closed 1 year ago

antontre1 commented 1 year ago

situation: Picture was not able to be correctly displayed in a record referring to an active storage picture

error identified: incorrect link given to show the picture in the view

fix provided: replace thumb_url in image_html = v.image_tag(thumb_url, class: 'img-thumbnail') by resource_url

coveralls commented 1 year ago

Coverage Status

Coverage: 95.911% (+0.02%) from 95.887% when pulling 08ee3f40c4563ab2e3201060bfc52e23a02f14e0 on antontre1:fix-activerecord-image-path into 2ee43deb1fa8d3a9e3ea0e589c1687d684e19ad6 on railsadminteam:master.

mshibuya commented 1 year ago

What this does is just breaking the functionality of thumbnail feature. Please create an issue first, then we can talk about the solutions.