search

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.87k stars 2.25k forks source link

Fix for heroku build error #3607

Closed greghaygood closed 1 year ago

greghaygood commented 1 year ago

Heroku rejected my builds using rails_admin 3.1.1 until I added braces around these SCSS variables.

coveralls commented 1 year ago

Coverage Status

Changes unknown when pulling f9bcb85f451fd4972e6955c27387d06c150a0104 on greghaygood:master into on railsadminteam:master.

mshibuya commented 1 year ago

Could you try yarn upgrade first? I suppose the issue you're having is the same one as #3565.

greghaygood commented 1 year ago

Sorry for the delay - Yes, I tried yarn-upgrading with the official package in place, but no luck.

mshibuya commented 1 year ago

Then please provide package.json and yarn.lock, then I can take a look. This fix is very workaround-ish, so we should identify what's causing the issue before merging in.

greghaygood commented 1 year ago

Sure, here you go. FYI I'm still getting the same error after updating to rails_admin 3.1.2.

Thanks for looking!

package.json.txt yarn.lock.txt

mshibuya commented 1 year ago

Looks like your @rails/webpacker npm package is locked on the very old version. Could you try using the latest one 5.4.4, along with upgrading the webpacker gem version in Gemfile. If the problem persists, please give me package.json, yarn.lock, and Gemfile again.

greghaygood commented 1 year ago

The syntax error/warning I was getting went away, so upgrading the webpacker npm package seems to have fixed this issue. Heroku is now reporting a different compile warning during deployment, but it didn't block the build. So we can close this PR if you want. Thanks!