fix is_blank and is_present filters for uuid columns

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data

MIT License

7.87k stars 2.25k forks source link

fix is_blank and is_present filters for uuid columns #3629

Closed ozenbusra closed 1 year ago

ozenbusra commented 1 year ago

Using "is present" and "is blank" filters for UUID columns causes "PG::InvalidTextRepresentation" since UUID type cannot be represented with empty string.

Empty string search is removed for UUID as well as boolean, integer, decimal and float columns.

mshibuya commented 1 year ago

Thanks, the change itself looks good. Please resolve the Rubocop offenses to get this merged. https://github.com/railsadminteam/rails_admin/actions/runs/5146285290/jobs/9265110540?pr=3629

ozenbusra commented 1 year ago

Thanks, the change itself looks good. Please resolve the Rubocop offenses to get this merged. https://github.com/railsadminteam/rails_admin/actions/runs/5146285290/jobs/9265110540?pr=3629

I resolved the offenses that occured in the files I changed in this PR. However, there are 2 more offenses, should I also resolve them?

mshibuya commented 1 year ago

No need for that, thanks!