railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.87k stars 2.25k forks source link

Integration with ViteRuby #3643

Closed bankair closed 11 months ago

bankair commented 11 months ago

Hey folks,

Here, at Simundia, we are using rails_admin, and we are loving it so far. Congrat's on the work you did on this.

Since we are currently in the process of migrating our assets pipeline from webpack to vite, we made a small fork which adapt the generators and the engine in order to be able to work with ViteRuby as well.

However, we don't want to maintain this fork forever, and we are wondering if you'd be keen to merge our diff with rails_admin's trunk.

Please tell us if you need anything from us in order to move forward with it.

Have a great day!

coveralls commented 11 months ago

Coverage Status

coverage: 95.951% (-0.09%) from 96.038% when pulling 677cffc42b016b3090720862da83b7b627a83e55 on simundia:vite-asset-source-support into 5ca8ccbf4dbd23857a323aaa6985832fe9b5c38c on railsadminteam:master.

mshibuya commented 11 months ago

Great work! Some more changes are needed, but I can take care of them. Thank you so much 🏅

bankair commented 11 months ago

Great, thank you for taking care of the extra-mile!

coveralls commented 6 days ago

Coverage Status

Changes unknown when pulling 677cffc42b016b3090720862da83b7b627a83e55 on simundia:vite-asset-source-support into on railsadminteam:master.