railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.89k stars 2.25k forks source link

Remove Rails UJS as a dependency #3644

Open caiofct opened 1 year ago

caiofct commented 1 year ago

Is your feature request related to a problem? Please describe.

Turbo was introduced since version 3.0 of this gem and now has support for every feature Rails UJS has. We wouldn't need to have Rails UJS as a dependency anymore and, even thought Turbo and UJS can coexist in a Rails project, having one less dependency would be ideal IMHO.

Describe proposed solution(s) Migrate the Rails UJS usage like data-method, data-confirm etc... to Turbo equivalents. There's a handy guide on how to perform the migration: https://dev.to/thomasvanholder/how-to-migrate-rails-ujs-to-hotwire-turbo-hdh

Additional context I still saw some method: usages through the codebase here but not sure if there's any other things that might be blocking this migration or if it has been considered before.