Quote table_ and column_name for sorting

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data

MIT License

7.87k stars 2.25k forks source link

Quote table_ and column_name for sorting #3652

Closed rnestler closed 4 months ago

rnestler commented 9 months ago

Fixes #1631.

rnestler commented 8 months ago

Any update on this?

coveralls commented 8 months ago

coverage: 96.021% (-0.02%) from 96.037% when pulling 68299c0cffb709adb05d133915fbdff2592bba17 on rnestler:fix/1631-quote-column-names into 13c90fdd95c3755035b44264dc61e4b65c09ff12 on railsadminteam:master.

mshibuya commented 4 months ago

Great job, thank you!

rnestler commented 4 months ago

Ah sorry I forgot about that. I think I didn't add the regression test or RDBMS-specific test cases.

mshibuya commented 4 months ago

I'll handle that when I have time 👍