public_send for removed methods javascript_importmap_shim_nonce_configuration_tag

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data

MIT License

7.9k stars 2.26k forks source link

public_send for removed methods javascript_importmap_shim_nonce_configuration_tag #3668

Closed moskvin closed 10 months ago

moskvin commented 10 months ago

& javascript_importmap_shim_tag

coveralls commented 10 months ago

coverage: 95.995% (+0.1%) from 95.9% when pulling c451754a0d6d878126fac7d1ad63d24ffc54b409 on moskvin:master into af7414a98aa87cfe90d79cb0ed64962fb34c58f4 on railsadminteam:master.

Halphas commented 10 months ago

plis merrrge :D :(

mshibuya commented 10 months ago

What problem is this change trying to address?

moskvin commented 10 months ago

I was trying resolve issue when I got a crash error about javascript_importmap_shim_nonce_configuration_tag is not found from Rails (7.1.3) + importmap-rails (2.0.1) and rails_admin (3.1.2). ref #3666 (Support importmap-rails 2.0 - 24380d53f7c82eef4758e96a0b98e9d4333a806d)

mshibuya commented 10 months ago

Sorry but I don't understand, why https://github.com/railsadminteam/rails_admin/commit/24380d53f7c82eef4758e96a0b98e9d4333a806d doesn't work?

Halphas commented 10 months ago

I'm too new in ruby to understand this but i when I updated rails from 7.1.2 to 7.1.3 hit went sideways :D, when i applied this code in the sources i could access but on my deployment systems obviously im building packages from their respective repos and wont be editing sources :x pls merge pls

moskvin commented 10 months ago

Sorry but I don't understand, why 24380d5 doesn't work?

What should I provide to you to explain more the problem? Should I provide a project example with the crash?

mshibuya commented 10 months ago

https://github.com/railsadminteam/rails_admin/commit/24380d53f7c82eef4758e96a0b98e9d4333a806d is the fix which should have already addressed https://github.com/railsadminteam/rails_admin/discussions/3666. So if you're saying you have the another issue that wasn't fixed by https://github.com/railsadminteam/rails_admin/commit/24380d53f7c82eef4758e96a0b98e9d4333a806d, you need to provide an example. Have you already tested with the rails_admin master branch?

moskvin commented 10 months ago

24380d5 is the fix which should have already addressed #3666. So if you're saying you have the another issue that wasn't fixed by 24380d5, you need to provide an example. Have you already tested with the rails_admin master branch?

I apologise for the inconvenience, and I appreciate your guidance. It turns out that specifying the development branch indeed resolved the issue, as you suggested.

gem 'rails_admin', github: 'railsadminteam/rails_admin', branch: 'master'