Allow turbo-rails 2 in gemspec

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data

MIT License

7.87k stars 2.25k forks source link

Allow turbo-rails 2 in gemspec #3671

Closed bb closed 5 months ago

bb commented 5 months ago

See https://github.com/railsadminteam/rails_admin/issues/3661#issuecomment-1927663367

coveralls commented 5 months ago

coverage: 95.9%. remained the same when pulling f6c452330669a63a8376e62528d9b16ff025109c on bb:patch-1 into af7414a98aa87cfe90d79cb0ed64962fb34c58f4 on railsadminteam:master.

mshibuya commented 5 months ago

CI is failing, but I can handle it. Thanks!

bb commented 5 months ago

Thank you!

xijo commented 2 weeks ago

@pathakh any chance to release this soon-ish? Feels bad to force us all to stay on an outdated version of turbo :|

bb commented 6 days ago

@mshibuya thanks for providing the hotfixes 3.1.3+4. Are there any plans to create a new minor release from master (which includes this PR)?

If not, could you please update the patch version in master to 3.1.4 so we can refer to master in our bundle without having to ignore https://github.com/railsadminteam/rails_admin/security/advisories/GHSA-8qgm-g2vv-vwvc in our audits.

mshibuya commented 4 days ago

I've just released a pre-release version 3.2.0.beta. The master was also bumped to that version. It'll take some more time for the next minor release, but please give feedback so it can happen earlier 🙏

bb commented 4 days ago

That's great, thank you! I tried 3.2.0.beta locally and in CI. Also converted an App from Sprockets to Ruby-Vite (thanks to #3643) which also works for me. Good to go, from my perspective. 🚀

Edit: there are some SASS deprecation warnings inside node_modules/bootstrap/scss/. Not a show-stopper but maybe good to know. They're addressed here: https://github.com/twbs/bootstrap/pull/40623