search

railsadminteam / rails_admin

RailsAdmin is a Rails engine that provides an easy-to-use interface for managing your data
MIT License
7.89k stars 2.25k forks source link

Propshaft support #3675

Open wlipa opened 7 months ago

wlipa commented 7 months ago

The rails_admin gem does not work in apps that use Propshaft to serve assets instead of Sprockets. I was able to work around it like this, but it would be nice to support Propshaft out of the box.

config/initializers/assets.rb:

# stub for rails_admin compat
class Sprockets
  def self.register_bundle_processor(...) = nil
end

Also, one needs to grab application.js, application.css, and the fa-solid woff2 font from a sprockets based rails_admin live page. Place in app/assets/stylesheets/rails_admin and app/assets/javascripts/rails_admin.

The CSS needs to be modified to change the fa-solid url to a propshaft compilable url (i.e, take out the digest).

koenhandekyn commented 4 months ago

it probably could be quite simple indeed, by 'installing' compiled versions of the assets, that simply could be checked in? maybe from a generator?

as bootstrap is now supporting theming and configuration with plain css variables, the need for sass actually is much smaller for most uses cases anyhow.

vpereira commented 4 months ago

After this https://github.com/railsadminteam/rails_admin/issues/3399 I was able to run propshaft with rails admin without problems