search

railsbridge-boston / railsbridgeboston_dot_org

This is the RailsBridge Boston website.
https://www.railsbridgeboston.org/
0 stars 2 forks source link

Embedding typekit with default code #19

Closed conchan closed 9 years ago

conchan commented 10 years ago

Removed async option because of FOUT

conchan commented 10 years ago

@mxie could you check this over? :grin:

mxie commented 10 years ago

How come we want to do the .erb route instead of keeping source/javascripts/typekit.js?

conchan commented 10 years ago

The typekit.js file held Typekit's async function, which resulted in FOUT since it ends up finish loading after the page. Loading their provided <script>s at head fixes that, and I have it in an .erb since it's using the <script> tag—should I do it differently?

mxie commented 9 years ago

I remember you said that you resolved the issue by contacting Typekit. Are we all set with this now or do we still need to figure something out?

conchan commented 9 years ago

Oh jeez I don't remember exactly what happened. I do remember contacting Typekit and we were able to fix the problem—but I think the problem was that none of the fonts were being loaded at all.

FOUT seems to be still happening on production right now, so I think this PR DOES fix that.

mxie commented 9 years ago

Ok cool. I think this is good to squash and merge then.