Add testing curriculum

[akanshmurthy]

CC: @careful-with-that-axe @schaui6 @lilliealbert @aneyzberg

This contains the addition of a new curricula related to testing software. The reason for the addition is that testing plays a hugely important rule in the real world for software quality control and is a supplement to the current curricula, which focus mainly on building software.

This was originally tested as part of https://www.bridgetroll.org/events/324. Then, after creating a more structured curriculum, the content was tested in a real RailsBridge event: https://www.bridgetroll.org/events/347. This PR is the culmination of the feedback from that event.

[careful-with-that-axe-zz]

Heya @akanshmurthy and @schaui6, @tjgrathwell is out for a bit, possibly longer so I will review it. I should be able to to that in the next couple of days and then we will get it folded into the curricula. And of course anyone else watching this your comments and feedback are appreciated as well.

Congrats on the successful class and thanks again for all of your hard work making this happen. :)

[careful-with-that-axe-zz]

Oh hey! Could you include a live link to this as well? I might have another couple people look at it quickly and that is easier to do from a live heroku app.

[careful-with-that-axe-zz]

Also @tjgrathwell might still be around so if you are please go ahead yourself with comments and such!

[akanshmurthy]

Sure thing!

https://railsbridgetesting.herokuapp.com/testing/

[camillevilla]

Hi @akanshmurthy and @schaui6! I'm testing out this curriculum and I found some errors on "Types Of Tests". In Steps 2 and 4, the tests don't pass without adding stuff (associations, resources, actions, etc). This is a great chance to do some error-driven teaching, so I'm working on fleshing out Steps 2 and 4. Just wanted to give you a heads-up, I'm working on a PR for ya!

[akanshmurthy]

@camillevilla : awesome, thanks! I do notice that the class Orange at the top only displays class Orange. It's supposed to display a whole class file with the associations. That might be an easy fix (I think the indentation in the step file might be a culprit). And, for the resources/actions, we could just state that along with "Copy the below test, paste it into the oranges controller spec file, create the relevant view files..."? Thoughts?

[akanshmurthy]

Bump.

[camillevilla]

hi @akanshmurthy! Here's what I've added:

• typo: Rspec.describe --> RSpec.describe
• split things up into additional steps (e.g. defining a tree model)
• correction on when association and controller tests are / are not passing (e.g. Tests currently fail where the curriculum suggests "Great, that test should be passing!")

I did some work in my own fork, but I'm not able to open a PR for your fork. Not sure if this is a GitHub permissions thing or just confusion on my part. Could you give me contributor permissions for akanshmurthy/docs and I can make a PR there?

[akanshmurthy]

@camillevilla : I've added you as a collaborator. Try now?

@careful-with-that-axe or @tjgrathwell : can we please get a review of this PR? It's been 4 weeks...

[camillevilla]

Great, thanks @akanshmurthy! PR is hanging out for your review.

[careful-with-that-axe-zz]

@akansh: Sorry! I am just wrapping up a vacation but will be able to review tomorrow afternoon.

Thanks for patience and also the ping so I do the right thing despite getting distracted!

On Mon, May 29, 2017 at 12:30 PM, Camille Villa notifications@github.com wrote:

Great, thanks @akanshmurthy https://github.com/akanshmurthy! PR is hanging out for your review.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/railsbridge/docs/pull/613#issuecomment-304719473, or mute the thread https://github.com/notifications/unsubscribe-auth/ADV4z4_tr6TeLglawQ-4sjhbQa0r5eUyks5r-xzLgaJpZM4NM2dB .

[careful-with-that-axe-zz]

Hi @akanshmurthy I have been busier than I expected so I had no time last night. I am going to try to swing around to it today during lunch. Thanks again for patience.

[akanshmurthy]

@careful-with-that-axe : ok, thanks. I think Camille's updates have been merged in too.

[tjgrathwell]

working on merging this in soon with some updates

[tjgrathwell]

Okay, merged and deployed :rocket: - http://docs.railsbridge.org/testing-rails-applications

I named the curriculum "Testing Rails Applications" for now, we can change it again later if that seems badly scoped or worded. But usually names that are a little longer and unique are good because in the future it's easier to search the code for references to testing-rails-applications than just testing.

Made some amendments in 492d7f2082fe4e66d1bd1c5aa4fdd516725aefac

⚠️ ⚠️ ⚠️

I also rebased all the commits, so anyone who was working on this should hard-reset to the current master if you want to continue development

⚠️ ⚠️ ⚠️

[akanshmurthy]

Awesome, thanks!!