search

railsbump / app

Check which gems are compatible with which Rails version!
https://railsbump.org
MIT License
152 stars 20 forks source link

Add exception if gem is not found #61

Closed alexeyschepin closed 3 years ago

alexeyschepin commented 3 years ago

Based on https://github.com/railsbump/app/issues/59

lockfile upload fils if at least one gem is not found. I think such gems must be rather ignored.

The solution is not tested because I wasn't able to run the app locally.

manuelmeurer commented 3 years ago

Thanks a lot, @alexeyschepin! Could you address the comment I made?

alexeyschepin commented 3 years ago

@manuelmeurer I've made a new commit.

manuelmeurer commented 3 years ago

Thanks @alexeyschepin and sorry for the delay!

I'm not sure why I asked you to change it so that gemmy is passed to the error instead of gemmy_name, it doesn't make sense since, well, there is no gemmy. 🤦‍♂️

I merged anyways and will undo the last commit.